Skip to content

Conversation

@diafour
Copy link
Member

@diafour diafour commented Nov 1, 2025

Description

Update base images to v0.53.8 to bump golang to 1.24.9 and mitigate newer CVEs.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section:
type:
summary:

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 1, 2025

Reviewer's Guide

This PR bumps the base images version to v0.5.38 to upgrade Go to 1.24.9 and mitigate CVEs, updating all related image digests across base, builder, libs, and tools, and introduces a Taskfile target to list images in use.

Flow diagram for new Taskfile target: base-images-in-use

flowchart TD
  A["Task: base-images-in-use"] --> B["check-werf"]
  A --> C["check-yq"]
  A --> D["Run: werf config render"]
  A --> E["Run: SVACE_ENABLED=true werf config render"]
  D --> F["Pipe to yq -ojson"]
  E --> F
  F --> G["Pipe to jq .fromImage"]
  G --> H["Pipe to sort"]
  H --> I["Pipe to uniq -c"]
Loading

File-Level Changes

Change Details Files
Bump base-images version, add Go alias, and update all image digests
  • Updated version annotation from v0.5.27 to v0.5.38
  • Added alias for builder/alt-go-svace pointing to Go 1.24.9 image
  • Replaced SHA256 digests for base, builder, libs, and tools images to reflect new versions
build/base-images/deckhouse_images.yml
Add Taskfile target for listing in-use base images
  • Introduced new "base-images-in-use" task to render and count fromImage entries
  • Enabled SVACE mode rendering to include alternative images
Taskfile.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • There’s a typo in the new alias comment (“bulder” → “builder”) and the alias block sits above the version header—please align it with the existing version‐bump format so automated tooling still picks up the new version correctly.
  • Consider wiring the new base-images-in-use Task into your CI or pre-commit pipeline so outdated base image SHA updates get flagged automatically.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- There’s a typo in the new alias comment (“bulder” → “builder”) and the alias block sits above the version header—please align it with the existing version‐bump format so automated tooling still picks up the new version correctly.
- Consider wiring the new base-images-in-use Task into your CI or pre-commit pipeline so outdated base image SHA updates get flagged automatically.

## Individual Comments

### Comment 1
<location> `build/base-images/deckhouse_images.yml:1` </location>
<code_context>
-# version=v0.5.27
+# alias for absent bulder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38)
+builder/alt-go-svace: "sha256:82659c57ddfeaa988ea73c10da0f69d217f0b5a59db723e1b6834bfee35d69c8" # fromImage: builder/golang-alt-1.24.9
+
</code_context>

<issue_to_address>
**nitpick (typo):** Typo in 'bulder' should be 'builder'.

Please update 'bulder' to 'builder' in the comment for accuracy.

```suggestion
# alias for absent builder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38)
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -1,280 +1,297 @@
# version=v0.5.27
# alias for absent bulder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Typo in 'bulder' should be 'builder'.

Please update 'bulder' to 'builder' in the comment for accuracy.

Suggested change
# alias for absent bulder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38)
# alias for absent builder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38)

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants