-
Notifications
You must be signed in to change notification settings - Fork 2
chore(module): update base images to bump golang to 1.24.9 #1653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.0-cse
Are you sure you want to change the base?
chore(module): update base images to bump golang to 1.24.9 #1653
Conversation
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Reviewer's GuideThis PR bumps the base images version to v0.5.38 to upgrade Go to 1.24.9 and mitigate CVEs, updating all related image digests across base, builder, libs, and tools, and introduces a Taskfile target to list images in use. Flow diagram for new Taskfile target: base-images-in-useflowchart TD
A["Task: base-images-in-use"] --> B["check-werf"]
A --> C["check-yq"]
A --> D["Run: werf config render"]
A --> E["Run: SVACE_ENABLED=true werf config render"]
D --> F["Pipe to yq -ojson"]
E --> F
F --> G["Pipe to jq .fromImage"]
G --> H["Pipe to sort"]
H --> I["Pipe to uniq -c"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- There’s a typo in the new alias comment (“bulder” → “builder”) and the alias block sits above the version header—please align it with the existing version‐bump format so automated tooling still picks up the new version correctly.
- Consider wiring the new base-images-in-use Task into your CI or pre-commit pipeline so outdated base image SHA updates get flagged automatically.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a typo in the new alias comment (“bulder” → “builder”) and the alias block sits above the version header—please align it with the existing version‐bump format so automated tooling still picks up the new version correctly.
- Consider wiring the new base-images-in-use Task into your CI or pre-commit pipeline so outdated base image SHA updates get flagged automatically.
## Individual Comments
### Comment 1
<location> `build/base-images/deckhouse_images.yml:1` </location>
<code_context>
-# version=v0.5.27
+# alias for absent bulder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38)
+builder/alt-go-svace: "sha256:82659c57ddfeaa988ea73c10da0f69d217f0b5a59db723e1b6834bfee35d69c8" # fromImage: builder/golang-alt-1.24.9
+
</code_context>
<issue_to_address>
**nitpick (typo):** Typo in 'bulder' should be 'builder'.
Please update 'bulder' to 'builder' in the comment for accuracy.
```suggestion
# alias for absent builder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -1,280 +1,297 @@ | |||
| # version=v0.5.27 | |||
| # alias for absent bulder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Typo in 'bulder' should be 'builder'.
Please update 'bulder' to 'builder' in the comment for accuracy.
| # alias for absent bulder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38) | |
| # alias for absent builder/alt-go-svace (it builder/golang-alt-svace-1.24.9 in v0.5.38) |
Description
Update base images to v0.53.8 to bump golang to 1.24.9 and mitigate newer CVEs.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries