-
Notifications
You must be signed in to change notification settings - Fork 562
helm charts for open taco, ui adjustment for deploy #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
helm-charts/opentaco/Chart.yaml
Outdated
- name: postgresql | ||
version: "15.x.x" | ||
repository: https://charts.bitnami.com/bitnami | ||
condition: postgresql.enabled | ||
tags: | ||
- database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont think we should rely on bitnami here at all https://medium.com/@PlanB./the-death-of-free-bitnami-charts-and-what-it-means-for-your-infrastructure-8081344e2363
helm-charts/opentaco/Chart.yaml
Outdated
|
||
maintainers: | ||
- name: OpenTaco Team | ||
email: team@opentaco.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helm-charts/opentaco/Chart.yaml
Outdated
# Digger Backend - terraform orchestration | ||
- name: digger-backend | ||
version: "0.1.12" | ||
repository: "file://../digger-backend" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont you think our repository links of the parent repository should rely on OCI images of the child repositories instead?
helm-charts/README.md
Outdated
--create-namespace \ | ||
--values values.yaml | ||
# 1. Configure values file (see Configuration Checklist below) | ||
cp opentaco/values-test.yaml.example opentaco/values-test.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not expect people to clone the repo and use local files, we can instead just ask them to fetch the values from the published repo on ghcr.io like the step here https://www.runatlantis.io/docs/deployment.html#kubernetes-helm-chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that makes sense
helm-charts/README.md
Outdated
|
||
# 4. Deploy | ||
cd opentaco | ||
helm install opentaco . -f values-test.yaml -n opentaco |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably say something like helm repo opentaco ghcr.io://
import { Route as AuthenticatedDashboardDashboardReposConnectRouteImport } from './routes/_authenticated/_dashboard/dashboard/repos.connect' | ||
import { Route as AuthenticatedDashboardDashboardReposRepoIdRouteImport } from './routes/_authenticated/_dashboard/dashboard/repos.$repoId' | ||
import { Route as AuthenticatedDashboardDashboardProjectsProjectIdRouteImport } from './routes/_authenticated/_dashboard/dashboard/projects.$projectId' | ||
import { Route as AuthenticatedDashboardDashboardProjectsProjectidRouteImport } from './routes/_authenticated/_dashboard/dashboard/projects.$projectid' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file and the projectid intentionally commited or is it by accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is intentional the ui wasn't building without those changes
Add helm charts for opentaco cluster
Adjust UI deploy from netifly to portable
Clean up readme and helm chart instructions
AI used to iterate on the helm charts and clean up unused helm charts / settings from example implementations
Once this is merged I'll confirm the release pipelines work as expected. In packaging time we could also add more varied examples of configurations (this is pretty much happy path for cloud SQL/our setup)
i've tested a real version of test values