Fix ANSI color preservation across multiple log lines #13305
+245
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ANSI state tracking to the presenter struct, restoring color codes at the start of each line and properly resetting them at line end. Signed-off-by: neo <chojs990222@gmail.com>
chojs23
force-pushed
the
handle-ansi-color-logs
branch
from
cd62dd8 to
d94ede3
Compare
|
I don't think this is a feature we should support in Compose: While some process may only rely on coloring, ANSI-enabled output is used by many tools with cursor-position ANSI sequence (typically to show computation progress, same as Compose does) which will break Compose logs formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track ANSI color state across log lines so container output with color codes spanning multiple lines preserves formatting on all lines, not just the first.
This fix adds an ansiState field to the presenter struct to track active ANSI SGR (color/style) codes per container and restores them at the start of each line.
Only handles SGR codes (colors, bold, underline).
Fixes #12789