Handle fonts with Unicode full repertoire (U+10000 to U+10FFFF) #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 6, 2024
Author
|
Just pushed a small commit because I just faced a case where the keys of the cmap subtables were non-consecutives, going from |
Member
|
Thanks for keeping this alive. I'm hoping to switch to working on a release for FontLib in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the library to output fonts’ character set, I noticed some were missing characters (when compared with opentypejs’ output) because of glyphs being part of the Unicode full repertoire (U+10000 to U+10FFFF).
This commit updates
getUnicodeCharMap()to check the cmap subtables in reverse so the Unicode full repertoire Encoding ID comes first.