Make Token.Symbol property public #1815
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ParseResult.Tokenslist. This givesTokens, which contain embedded symbol references.Symboldirectly against predefinedArgumentandOptionobjects to ease identification.internalcode today requires something likeif (tokenOfInterest == new Token(tokenOfInterest.Value, TokenType.Option, optionOfInterest)) { /* match */ ... }, which works because of the overriddenToken.Equalsmethod.if (tokenOfInterest.Symbol == optionOfInterest) { /* match */ ... }Token.Symbolneeds to beinternal