Skip to content

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Nov 9, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/task/1211855463961045?focus=true

Description

Change rounding strategy from HALF_UP to ROUND_DOWN

Steps to test this PR

Pre steps

Upgrade

  • Install from branch
  • Purchase a test monthly subscription (Free Trial)
  • Cancel and wait until Free Trial expires OR wait until free trial is renewed to a paid monthly subscription
  • If expired after canceled, purchase a monthly subscription again
  • Go to Subscription Settings
  • Check Switch option is there with updated text "Switch to Yearly and Save 16%"
  • Select Switch option
  • Check copy for upgrade option is correct (16%)

Downgrade

  • Switch to yearly
  • Wait until screen refreshes
  • Select switch option
  • Check copy for downgrade option is correct (16%)

No UI changes

Copy link
Contributor Author

nalcalag commented Nov 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review November 9, 2025 14:22
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nalcalag nalcalag merged commit 9497db6 into develop Nov 13, 2025
17 of 18 checks passed
@nalcalag nalcalag deleted the feature/noelia/round_down_yearly_savings branch November 13, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants