- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7.7k
feat(ledc): max resolution review #11226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
 👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
 Review and merge process you can expect ...
 | 
| Test Results 76 files   76 suites   14m 20s ⏱️ Results for commit 4cc8ba0. ♻️ This comment has been updated with latest results. | 
| Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target. 
 Click to expand the detailed deltas report [usage change in BYTES]
 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @SuGlider Is there anything needed to finish this PR? | 
| 
 Let me test it again based on master branch. | 
| Looks good to me, but the main reason for this was, that for example if you have 8 bits resolution you expect the duty to be from 0 - 255, but the LEDC works from 0 - 256, which uses 1 more bit. We can use the changes in your PR, but please also add a note to the documentation and existing examples. This can also be marked as breaking change, as if users have code from 0-255 they will not be fully ON when use the 255 using the  | 
| As it is a breaking change, isn't it better to postpone it to v4.0.0 ? | 
| @lucasssvaz I have changed the milestone to 4.0.0. Also discussed to update the examples and add a note to docs. Tehn we will also add this to migration guide from 3.x to 4.0 | 
Description of Change
LEDC says that maximum duty value is 2^resolution_bits
Arduino
analogWrite()says taht the maximum duty is (2^resolution_bits) - 1Example for 8 bits resolution, LEDC max duty is 256 and Arduino
analogWrite()is 255.This PR changes the code to reflec exactly that.
When using LEDC functions, it will allow max duty to go to 2^resolution_bits.
When using Arduino API
analogWrite(), it will map duty (2^resolution_bits) - 1 to maximum value in LEDC before calling its function.By this way both are compatible to its own specification and allows all valid values to be used.
Tests scenarios
ESP32 and ESP32C6 using digital Logic Analyzer.
Related links
Fix #11049