fix(esp32): issues on starting touch sensor and attaching interrupt #11967
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👋 Hello AlexAls, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
AlexAls
changed the title
Test Results 76 files 76 suites 15m 3s ⏱️ Results for commit ba35f4c. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
P-R-O-C-H-Y
approved these changes
Oct 30, 2025
P-R-O-C-H-Y
requested changes
Oct 30, 2025
| return true; | ||
| } | ||
| if (enabled && (touch_sensor_start_continuous_scanning(touch_sensor_handle) != ESP_OK)) { | ||
| if (!enabled && (touch_sensor_start_continuous_scanning(touch_sensor_handle) != ESP_OK)) { |
There was a problem hiding this comment.
Hi, your approach will create a bug and touch will never start. PLease apply following fix!
Suggested change
| if (!enabled && (touch_sensor_start_continuous_scanning(touch_sensor_handle) != ESP_OK)) { | |
| if(!enabled) { | |
| log_e("Touch sensor not enabled!"); | |
| return false; | |
| } | |
| if (touch_sensor_start_continuous_scanning(touch_sensor_handle) != ESP_OK) { |
- change the error log message to:
Touch sensor failed to start continuous scanning!
P-R-O-C-H-Y
added
Status: In Progress ⚠️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
The order of arguments is mixed up when calling a function
__touchConfigInterrupt.Setting the threshold resets all other configuration parameters.
In function
touchStartusing "enable" instead of "not enable" in "if" condition.