Skip to content

Conversation

Nikhil012N
Copy link

Added http exceptions for better error handling created error handling middleware and add bun.lock to .gitignore file

…g middleware and add bun.lock to .gitignore file
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedhelmet@​8.1.010010010081100
Addedcors@​2.8.510010010081100
Addedcompression@​1.8.19910010083100

View full report

@ken-ten
Copy link

ken-ten commented Oct 18, 2025

i don't think this is even relevant, is there even any feature request for this

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. A few things: we don’t accept changes to the code style.

It seems this PR is trying to do two things — adding compression, helmet, and CORS to the Express core. I recommend opening a discussion about this instead of doing it all at once in a PR.

The second thing is adding HttpException. What’s the intention behind this? I’d suggest opening a discussion for that as well, since I don’t really understand the reason why you’d want to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants