[test] Improve filterStackFrame to only include user space code
#34842
+386
−987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Flight Server option `filterStackFrame` plays an essential role in collecting and emitting I/O info. Therefore it is important that we properly define it in our tests, so that only user space code is included. Otherwise we might end up chasing ghosts when debugging those tests.
github-actions
bot
added
the
React Core Team
|
Comparing: 5f2b571...e877fe7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
We used to do this and indeed it should really be the default. But @eps1lon wanted to include built-ins which is what the Next.js overridden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flight Server option
filterStackFrameplays an essential role in collecting and emitting I/O info. Therefore it is important that we properly define it in our tests, so that only user space code is included. Otherwise we might end up chasing ghosts when debugging those tests.