➕ Add typing-extensions to test requirements for Python < 3.9
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `typing-extensions` to `requirements-tests.txt` since `tests/test_main.py` imports it; but at the same time, since `typing` in the Python standard library provides both `Annotated` and `get_type_hints`, adapt the tests to use the standard library instead on Python 3.9 and later.
svlandeg
reviewed
Oct 27, 2025
svlandeg
changed the title
typing-extensions to test requirements for Python < 3.9
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
typing-extensionstorequirements-tests.txt, sincetests/test_main.pyimports it,annotated-doc/tests/test_main.py
Line 3 in a8a8b63
…but at the same time, since
typingin the Python standard library provides bothAnnotatedandget_type_hints, adapt the tests to use the standard library instead on Python 3.9 and later, and conditionalize thetyping-extensionsdependency accordingly.