Reconnect socket && worker ping #600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elestrias
force-pushed
the
RemoteWorkerPingRecconect
branch
2 times, most recently
from
13f02bb to
8fda0ae
Compare
turuslan
reviewed
Feb 17, 2022
Signed-off-by: elestrias <rus8-2002@mail.ru>
Elestrias
force-pushed
the
RemoteWorkerPingRecconect
branch
from
8fda0ae to
0ace090
Compare
wer1st
changed the title
ortyomka
reviewed
Feb 18, 2022
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 46.02% 45.98% -0.04%
==========================================
Files 715 715
Lines 32328 32382 +54
Branches 17885 17918 +33
==========================================
+ Hits 14880 14892 +12
- Misses 13102 13140 +38
- Partials 4346 4350 +4
🚀 New features to boost your workflow:
|
Signed-off-by: elestrias <rus8-2002@mail.ru>
|
The problem I could see is that with connection retry we can connect to that socket with same host:port but it won't be the same process f e, instead of worker with gpu will be connected worker without gpu, problem is that we don't make changes in miner's worker info |
Signed-off-by: elestrias <rus8-2002@mail.ru>
Elestrias
force-pushed
the
RemoteWorkerPingRecconect
branch
from
b3d5161 to
5c5067a
Compare
ortyomka
approved these changes
Feb 21, 2022
turuslan
reviewed
Feb 21, 2022
Signed-off-by: elestrias <rus8-2002@mail.ru>
turuslan
approved these changes
Feb 21, 2022
Signed-off-by: elestrias <rus8-2002@mail.ru>
…ct/cpp-filecoin into RemoteWorkerPingRecconect
Elestrias
commented
Feb 22, 2022
Signed-off-by: elestrias <rus8-2002@mail.ru>
…ct/cpp-filecoin into RemoteWorkerPingRecconect
wer1st
reviewed
Mar 14, 2022
| } | ||
| } | ||
| chans.clear(); | ||
| reconnect(3, std::chrono::seconds(10)); |
There was a problem hiding this comment.
Use named variable or const instead of magic number 3
| socket->async_write(boost::asio::buffer(buffer.data(), buffer.size()), | ||
| [=](auto &&ec, auto) { | ||
| std::lock_guard lock{mutex}; | ||
| writing = false; |
There was a problem hiding this comment.
you change writing under the guard, but it is read and changed above without any guard. If you want to avoid race condition in multithreading, please use more consistent approach.
There was a problem hiding this comment.
Moreover, you provide data by copy [=], not by refs. This change doesn't make any sense in this case.
| } | ||
|
|
||
| void Client::reconnect(int counter, std::chrono::milliseconds wait) { | ||
| if (reconnecting) return; |
| logger_->info( | ||
| "Starting reconnect to {}:{}", client_data.host, client_data.port); | ||
| for (int i = 0; i < counter; i++) { | ||
| std::this_thread::sleep_for(wait*(i+1)); |
There was a problem hiding this comment.
Suggested change
| std::this_thread::sleep_for(wait*(i+1)); | |
| std::this_thread::sleep_for(wait * (i + 1)); |
|
|
||
| namespace fc::remote_worker { | ||
| using api::ApiVersion; | ||
| using api::VersionResult; |
There was a problem hiding this comment.
Not used anymore, remove
Suggested change
| using api::VersionResult; |
Comment on lines
910
to
+911
| } | ||
| void LocalWorker::ping(std::function<void(const bool resp)> cb) { |
There was a problem hiding this comment.
Suggested change
| } | |
| void LocalWorker::ping(std::function<void(const bool resp)> cb) { | |
| } | |
| void LocalWorker::ping(std::function<void(const bool resp)> cb) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: elestrias rus8-2002@mail.ru
Description of the Change
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]