Skip to content

Conversation

@sheldonrobinson
Copy link

Fixes #167

Changes

  1. Bump to version 0.9.4+1
  2. In src/serious_python_windows/windows/CMakeLists.txt Using CMake InstallRequiredSystemLibraries module to handle MSVC redistributables
  3. In src/serious_python_platform_interface/pubspec.yaml, src/serious_python/pubspec.yaml Updated archive package from 3.6.1 to 4.0.7
  4. In src/serious_python_platform_interface/lib/src/utils.dart Migrated to new ZipDecoder API

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2025

CLA assistant check
All committers have signed the CLA.

@FeodorFitsner
Copy link
Contributor

Flutter 3.7.0? Is that a typo?

@sheldonrobinson
Copy link
Author

sheldonrobinson commented Oct 27, 2025

No not typo, taken from src/serious_python/pubspec.yaml

environment:
  sdk: ">=3.0.0 <4.0.0"
  flutter: ">=3.7.0"

Probably should change it to flutter: ^3.35.x

The PR addresses the conflict between image: ^4.5.4 and archive: ^3.6.1 which prevented migration to flutter: ^3.35.x

Also fixed the flet_example to use github repository for flet: ^0.7.0

My environment is

flutter doctor -v
[√] Flutter (Channel stable, 3.35.7, on Microsoft Windows [Version 10.0.26200.6901], locale en-US) [646ms]
    • Flutter version 3.35.7 on channel stable at C:\Users\xxx\develop\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision adc9010625 (6 days ago), 2025-10-21 14:16:03 -0400
    • Engine revision 035316565a
    • Dart version 3.9.2
    • DevTools version 2.48.0
    • Feature flags: enable-web, enable-linux-desktop, enable-macos-desktop, enable-windows-desktop, enable-android,
      enable-ios, cli-animations, enable-lldb-debugging

[√] Windows Version (11 Pro for Workstations 64-bit, 25H2, 2009) [1,811ms]

[√] Android toolchain - develop for Android devices (Android SDK version 36.0.0) [3.9s]
    • Android SDK at C:\Users\xxx\AppData\Local\Android\Sdk
    • Emulator version 36.2.12.0 (build_id 14214601) (CL:N/A)
    • Platform android-36, build-tools 36.0.0
    • ANDROID_HOME = C:\Users\xxx\AppData\Local\Android\Sdk
    • Java binary at: C:\Users\xxx\AppData\Local\Programs\Android Studio\jbr\bin\java
      This is the JDK bundled with the latest Android Studio installation on this machine.
      To manually set the JDK path, use: `flutter config --jdk-dir="path/to/jdk"`.
    • Java version OpenJDK Runtime Environment (build 21.0.7+-13880790-b1038.58)
    • All Android licenses accepted.

[√] Chrome - develop for the web [292ms]
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.14.18 (October 2025)) [291ms]
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.14.36616.10
    • Windows 10 SDK version 10.0.26100.0

[√] Android Studio (version 2025.1.3) [183ms]
    • Android Studio at C:\Users\xxx\AppData\Local\Programs\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.7+-13880790-b1038.58)

[√] IntelliJ IDEA Community Edition (version 2025.2) [181ms]
    • IntelliJ at C:\Users\xxx\AppData\Local\Programs\IntelliJ IDEA Community Edition
    • Flutter plugin version 87.1
    • Dart plugin version 252.25557.23

[√] VS Code (version 1.105.0) [14ms]
    • VS Code at C:\Users\xxx\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.120.0

[√] Connected device (3 available) [305ms]
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.26200.6901]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 141.0.7390.123
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 141.0.3537.99

[√] Network resources [320ms]
    • All expected network resources are available.

• No issues found!

@sheldonrobinson sheldonrobinson changed the title Update to support flutter 3.7.0 Update to support flutter 3.35 Oct 27, 2025
@FeodorFitsner
Copy link
Contributor

Tests are failing - please take a look: https://github.com/flet-dev/serious-python/actions/runs/18846569647?pr=178
I assume the issue is here: https://github.com/flet-dev/serious-python/pull/178/files#diff-15986c44d91c557347901096848806386c4a08e84cbc89ff24abf1933a196d77L38-R41 as serious_python should work with both Flet 0.28.x and Flet v1.

@sheldonrobinson
Copy link
Author

I believe I have identified the issues.
It will required a migration for flet to supppot flutter 3.35 as there were some breaking changes in:

This looks like a bigger version bump as breaks 0.28.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency conflicts for archive 3.6.1 on flutter 3.35

3 participants