Skip to content

Conversation

@seveas
Copy link
Contributor

@seveas seveas commented Nov 8, 2024

This documents the functionality added in fluent/fluent-bit#9567

@seveas seveas requested review from a team as code owners November 8, 2024 09:46
Signed-off-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
@eschabell eschabell requested a review from esmerel October 22, 2025 00:07
@eschabell eschabell self-assigned this Oct 22, 2025
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor waiting-on-review Waiting on a review from mainteners labels Oct 22, 2025
@eschabell
Copy link
Collaborator

@esmerel can you give this a look?

@eschabell
Copy link
Collaborator

@seveas can you resolve the conflicts here? I also nudged you on the code PR fluent/fluent-bit#9567 for actions needed to proceed there.

Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edit suggestions

WantedBy=multi-user.target
```

`LogExtraFields` will make the specified fields appear in the log output. The `Systemd` plugin will look for a `FLUENT_BIT_PARSER` field and use it to parse the `MESSAGE` field. If the parser is not found or parsing fails, the unparsed message is added to the log entry as if no parser was specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`LogExtraFields` will make the specified fields appear in the log output. The `Systemd` plugin will look for a `FLUENT_BIT_PARSER` field and use it to parse the `MESSAGE` field. If the parser is not found or parsing fails, the unparsed message is added to the log entry as if no parser was specified.
`LogExtraFields` adds the specified fields to the log output. The `Systemd` plugin looks for a `FLUENT_BIT_PARSER` field and uses it to parse the `MESSAGE` field. If the parser is not found or parsing fails, the unparsed message is added to the log entry as if no parser was specified.

{% endtab %}
{% endtabs %}
### Parsing the MESSAGE field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Parsing the MESSAGE field
### Parsing the `MESSAGE` field

@esmerel
Copy link
Contributor

esmerel commented Oct 28, 2025

It also looks like the conflict can be resolved safely by accepting the incoming changes, but github has a bad habit of marking suggestions as outdated when you merge things so I'm not doing it myself this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes waiting-on-code-merge waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants