Skip to content

Conversation

@patchwork01
Copy link
Collaborator

@patchwork01 patchwork01 commented Nov 3, 2025

Changes included:

  • Add artefacts deployment ID instance property
  • Set default values for jars bucket and ECR repository prefix
    • Jars bucket is no longer set in PopulateInstanceProperties
    • Added SleeperArtefactsLocation, used in CDK, clients and system test code
    • Stopped setting jars bucket property in system tests to replicate PopulateInstanceProperties
    • Fixed documentation for ECR repository prefix, user jars instance properties
  • Stop creating jars bucket outside of CDK
    • Add JarsBucketCreator for use in tests
    • Remove code from SyncJars
    • Remove code from tear down
  • Stop creating ECR repositories outside of CDK
    • Remove code from UploadDockerImagesToEcr
    • Remove code from tear down
  • Deploy SleeperArtefactsCdkApp in:
    • DeployInstance (used in all instance deployment scripts/automation)
    • AwsSystemTestDeploymentDriver (also added missing override annotations)
  • Add artefacts deployment to tear down script

Make sure you have checked all steps below.

Issue

  • My PR fully resolves the following issues. I've referenced an issue in the PR title, for example "Issue 1234 - My
    Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
    for your progress.

Tests

  • My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
    • Updated existing tests
    • Ran SetupInstanceST in AWS
    • Tested deployAll deployment in AWS
    • Ran deployExisting script on instance deployed with deployAll

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@patchwork01 patchwork01 force-pushed the 5390-use-artefacts-cdk-app branch from 47e29d2 to 13366c5 Compare November 3, 2025 14:13
@patchwork01 patchwork01 changed the base branch from develop to 5389-cdk-app-to-deploy-jars-bucket-and-ecr-repositories November 3, 2025 14:13
@patchwork01 patchwork01 changed the base branch from 5389-cdk-app-to-deploy-jars-bucket-and-ecr-repositories to 5389-artefacts-cdk November 3, 2025 14:14
Base automatically changed from 5389-artefacts-cdk to develop November 4, 2025 09:20
@patchwork01 patchwork01 force-pushed the 5390-use-artefacts-cdk-app branch from b9f48a4 to 55f1cc0 Compare November 5, 2025 11:36
@patchwork01 patchwork01 changed the base branch from develop to 5972-refactor-reading-cdk-context November 5, 2025 11:37
@patchwork01 patchwork01 added the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Nov 5, 2025
@patchwork01 patchwork01 force-pushed the 5390-use-artefacts-cdk-app branch from 55f1cc0 to fa3111c Compare November 5, 2025 12:02
@patchwork01 patchwork01 changed the base branch from 5972-refactor-reading-cdk-context to 5974-adjust-artefacts-cdk November 5, 2025 12:03
@patchwork01 patchwork01 force-pushed the 5390-use-artefacts-cdk-app branch from fa3111c to ee9efb4 Compare November 5, 2025 15:08
@patchwork01 patchwork01 changed the base branch from 5974-adjust-artefacts-cdk to 5976-refactor-invoking-cdk November 5, 2025 15:09
@patchwork01 patchwork01 marked this pull request as ready for review November 10, 2025 11:06
@patchwork01 patchwork01 added needs-reviewer Pull requests that need a reviewer to be assigned pr-base-for-stacking Base for stacked pull requests (a dependency for others, where this PR's branch will be the base) labels Nov 10, 2025
@rtjd6554 rtjd6554 self-assigned this Nov 10, 2025
@rtjd6554 rtjd6554 removed the needs-reviewer Pull requests that need a reviewer to be assigned label Nov 10, 2025
Copy link
Collaborator

@rtjd6554 rtjd6554 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments attached

@patchwork01 patchwork01 changed the title Issue 5390- Use CDK app for deployment artefacts Issue 5390 - Use CDK app for deployment artefacts Nov 10, 2025
@patchwork01 patchwork01 merged commit 0aace9c into develop Nov 13, 2025
8 checks passed
@patchwork01 patchwork01 deleted the 5390-use-artefacts-cdk-app branch November 13, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-base-for-stacking Base for stacked pull requests (a dependency for others, where this PR's branch will be the base)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use CDK-deployed jars bucket and ECR during deployment

3 participants