-
Notifications
You must be signed in to change notification settings - Fork 16
Issue 5390 - Use CDK app for deployment artefacts #5961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47e29d2 to
13366c5
Compare
b9f48a4 to
55f1cc0
Compare
55f1cc0 to
fa3111c
Compare
fa3111c to
ee9efb4
Compare
rtjd6554
reviewed
Nov 10, 2025
java/clients/src/main/java/sleeper/clients/deploy/container/UploadDockerImages.java
Outdated
Show resolved
Hide resolved
rtjd6554
reviewed
Nov 10, 2025
java/clients/src/main/java/sleeper/clients/deploy/container/UploadDockerImages.java
Show resolved
Hide resolved
rtjd6554
reviewed
Nov 10, 2025
java/clients/src/main/java/sleeper/clients/deploy/container/CheckVersionExistsInEcr.java
Outdated
Show resolved
Hide resolved
rtjd6554
reviewed
Nov 10, 2025
.../clients/src/main/java/sleeper/clients/deploy/documentation/GeneratePropertiesTemplates.java
Outdated
Show resolved
Hide resolved
rtjd6554
reviewed
Nov 10, 2025
Collaborator
rtjd6554
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments attached
rtjd6554
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-base-for-stacking
Base for stacked pull requests (a dependency for others, where this PR's branch will be the base)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.