Issue 5869 - Deploy Sleeper as part of a larger CDK app #5993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patchwork01
force-pushed
the
5869-instance-cdk-stack
branch
from
d2b4d9a to
2c948ee
Compare
patchwork01
force-pushed
the
5869-instance-cdk-stack
branch
from
b7e4732 to
9e76ac8
Compare
patchwork01
changed the base branch from
5390-use-artefacts-cdk-app
to
6001-rename-stacks
patchwork01
changed the base branch from
6001-rename-stacks
to
6005-separate-instance-deployment-from-stack
patchwork01
changed the base branch from
6005-separate-instance-deployment-from-stack
to
6013-refactor-tracking-dead-letters
patchwork01
force-pushed
the
5869-instance-cdk-stack
branch
from
c1ea861 to
b7d0d54
Compare
patchwork01
added
needs-reviewer
rtjd6554
removed
the
needs-reviewer
rtjd6554
reviewed
Nov 13, 2025
| import sleeper.core.properties.instance.InstanceProperties; | ||
|
|
||
| /** | ||
| * Deploys an instance of Sleeper, including any configured optional stacks. Does not create Sleeper tables. If the |
Collaborator
There was a problem hiding this comment.
Might be better to have the "Does not create Sleeper tables" on a seperate line to make it more visible.
rtjd6554
reviewed
Nov 13, 2025
| DeployInstanceConfiguration configuration = DeployInstanceConfiguration.fromLocalConfiguration(propertiesFile); | ||
| return builder(configuration.getInstanceProperties(), s3Client, dynamoClient) | ||
| .tableProperties(configuration.getTableProperties()) | ||
| .validateProperties(!"false".equalsIgnoreCase(context.tryGetContext("validate"))) |
Collaborator
There was a problem hiding this comment.
Are inverted logic checks for this line and the one below the best for this here?
Collaborator
Author
There was a problem hiding this comment.
It seems necessary in order to handle the case where the context variable is unset. If we had validateProperties("true".equalsIgnoreCase(context.tryGetContext("validate"))), then it would default to false if the context variable is unset. We want it to default to true. It'd be good if there was a nicer way to do this.
Collaborator
Author
There was a problem hiding this comment.
I've avoided the inverted booleans.
rtjd6554
reviewed
Nov 13, 2025
Collaborator
rtjd6554
left a comment
rtjd6554
left a comment
There was a problem hiding this comment.
Small queries to answer
Base automatically changed from
6013-refactor-tracking-dead-letters
to
develop
November 13, 2025 10:25
patchwork01
added
needs-reviewer
Rob9786
approved these changes
Nov 13, 2025
patchwork01
removed
the
needs-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.