Switch to commands with args #969
Conversation
|
|
|
Integration tests report: appsharing.space |
|
Hey Arjun could you add a bit of detail to the PR description, specifically what the end-goal / motivation of this change is? I'm guessing this is prepping the ground for an implementation of a chat bot that can call these commands? |
| if (!layer || !['VectorLayer', 'ShapefileLayer'].includes(layer.type)) { | ||
| console.warn('Layer type not supported for GeoJSON export'); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm worried that the PR is a lot of addition without much reusing existing code. Could we try to extract some logic in reusable functions instead of copy pasting code?
There was a problem hiding this comment.
I have refactored the layer addition commands, i also tried to refactor the document operation commands but I think not much significant code is being repeated in there & i feel it's cleaner this way. Thoughts are welcome
|
Dope demo, Arjun! |
3 participants
Description
Port jupytercad/JupyterCAD#782 & jupytercad/JupyterCAD#783
This adds JupyterGIS commands to support argument-based execution (commandWithParams pattern) across document and processing actions.
It enables programmatic invocation of commands (e.g., from MCP agents, chatbots, or automation layers).
Rough demo:
Screen.Recording.2025-11-12.at.15.44.47.mp4
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--969.org.readthedocs.build/en/969/
💡 JupyterLite preview: https://jupytergis--969.org.readthedocs.build/en/969/lite