Skip to content

Conversation

@acoyner
Copy link
Contributor

@acoyner acoyner commented Nov 10, 2025

  • Downgraded compileSdk and targetSdk from 34 to 33, along with Compose BOM (2023.06.01) and Material library (1.10.0) to avoid API 34-only resources
  • Downgraded Kotlin from 2.1.0 to 1.9.25 with Compose compiler 1.5.15 for compatibility with Kotlin 1.x consumers
  • Added dependency resolution strategies to force SDK 33-compatible versions of androidx.activity (1.7.2), material3 (1.0.1), and material (1.10.0)
  • Updated Compose APIs: replaced HorizontalDivider with Divider and Icons.AutoMirrored.* with Icons.Filled.* for Compose 1.4.x compatibility

Fixes CXTOOLS-212

@acoyner acoyner requested a review from a team as a code owner November 10, 2025 18:32
return (null == prop) ? defValue : prop
}

subprojects {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here to say this is enforcing dependency constraints only for subprojects in Ditto Tools, and that its not enforced on consuming projects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rajramsaroop
Copy link
Contributor

Were we able to test this on an external app that had these issues?

@acoyner
Copy link
Contributor Author

acoyner commented Nov 14, 2025

@rajramsaroop Do we have any demo apps that have these issues?

@rajramsaroop
Copy link
Contributor

@rajramsaroop Do we have any demo apps that have these issues?

Not sure, don't think so. I tried creating an empty android project last night and setting the compile sdk to 33, but ran into some compile issues.

If you have time, you could try testing that way, or check if any of our demo apps or quickstart apps use compile sdk 33 or lower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants