-
Notifications
You must be signed in to change notification settings - Fork 13.4k
CUDA: support for weight clamp in top-k norm #16702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@CISC maybe need to rebase? Idk what happened |
Stacked PRs + squash-merge require linear history to work well. So the "best" way to do this is to no longer do merges to include upstream changes into a branch, but only do sequential, (interactive) rebases + force pushes from the bottom to the top of the stacked PR chain. If you:
Once again: Doing stacked PRs manually with git is possible but cumbersome, which is why there exists a plethora of tooling to manage stacked PRs in git |
|
It looks like this happened because you pulled in master, hopefully it is recoverable though, but if not just start a new one. |
161248c to
2ef5591
Compare
It is recoverable, but your branch needs to be updated. For now I can create this PR on master including your change, after you merge your PR we can merge this one |
2ef5591 to
c5acf1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to either check that the upper bound of the clamp is INFINITY, or just always do both sides of the clamp.
9dfe4ca to
d78a82c
Compare
d78a82c to
ad7409c
Compare
Support #16655