feat(agent,api): collect and expose status from dp grpc api #226
+409
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Temp artifacts published: |
There was a problem hiding this comment.
Pull Request Overview
This PR adds dataplane status collection functionality to the gateway agent, enabling periodic gathering of runtime status information from the dataplane including FRR daemon status and VPC peering statistics.
Key changes:
- Introduces a new status ticker (15-second interval) to periodically collect dataplane status via gRPC
- Adds new API types (
GatewayState,FRRStatus,DataplaneStatus,PeeringStatus) to represent collected status information - Refactors status update logic from a standalone function to a method with change detection to reduce unnecessary updates
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/agent/agent.go | Adds state field to Service struct, introduces statusTicker for periodic status collection, refactors updateStatus() as a method with change detection, and implements new collectDataplaneStatus() method to gather dataplane metrics |
| api/gwint/v1alpha1/gatewayagent_types.go | Defines new API types for gateway state tracking including GatewayState, DataplaneStatus, FRRStatus, and PeeringStatus structures |
| justfile | Updates controller-gen command to allow dangerous types (maps with non-string values) for CRD generation |
| docs/api.md | Auto-generated API documentation reflecting the new status-related types |
| config/crd/bases/gwint.githedgehog.com_gatewayagents.yaml | Auto-generated CRD manifest with new state field definitions |
| api/gwint/v1alpha1/zz_generated.deepcopy.go | Auto-generated DeepCopy methods for the new status types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frostman
force-pushed
the
dev/frostman/dp-state
branch
from
4b8a83f to
88eb2fb
Compare
|
🚀 Temp artifacts published: |
Fixes #224 Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Frostman
force-pushed
the
dev/frostman/dp-state
branch
from
c90ef41 to
cba6e24
Compare
|
🚀 Temp artifacts published: |
This is an automated commit created by GitHub Actions workflow, in the gateway-proto repository. Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Frostman
force-pushed
the
dev/frostman/dp-state
branch
from
cba6e24 to
1135e3c
Compare
Copilot finished reviewing on behalf of
Frostman
November 16, 2025 18:14
|
🚀 Temp artifacts published: |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224