Skip to content

Conversation

@cinderellasecure
Copy link

@cinderellasecure cinderellasecure commented Nov 3, 2025

As part of the organization's transition to default read-only permissions for the GITHUB_TOKEN, this pull request addresses a missing permission in the workflow that triggered a code scanning alert.

This PR explicitly adds the required read permissions to align with the default read only permission and is part of a larger effort for this OKR https://github.com/github/security-services/issues/455

Potential fixes for 2 code scanning alerts from the Copilot AutoFix: Missing Permissions in Workflows security campaign:

  • https://github.com/github/details-menu-element/security/code-scanning/5
    The best way to fix this issue is to add a permissions block either at the root of the workflow or within the specific job (publish-npm). The block should minimally allow only what is strictly required. Since this workflow reads code (via actions/checkout) and publishes to npm (which does not require GitHub repository writes), the best principle of least privilege setting is contents: read, unless there is a need for additional tokens (which isn't shown here). Any future needs for additional scopes can be added granularly. The change should be applied at either the root (top) of the workflow (line 2) or within the job definition at line 9, but root is preferred for clarity and ensuring coverage of all jobs.


  • https://github.com/github/details-menu-element/security/code-scanning/4
    The best way to fix this problem is to explicitly add a permissions block at the workflow root, above the jobs section in .github/workflows/nodejs.yml. This block should set the minimum required permissions for CI: contents: read. This change limits the permissions granted to the GITHUB_TOKEN for all jobs unless a job or step has a more specific (write) permission set later. This prevents accidental escalation of privileges and aligns the workflow with the principle of least privilege. No imports, definitions, or other code changes are needed; simply add the following block under the workflow name and before on: or jobs::

    permissions:
    contents: read

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

cinderellasecure and others added 2 commits November 3, 2025 12:36
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@cinderellasecure cinderellasecure marked this pull request as ready for review November 3, 2025 19:37
@cinderellasecure cinderellasecure requested a review from a team as a code owner November 3, 2025 19:37
Copilot AI review requested due to automatic review settings November 3, 2025 19:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explicit read-only permissions for repository contents to GitHub Actions workflows, following the principle of least privilege for workflow security.

  • Adds permissions.contents: read to the publish workflow
  • Adds permissions.contents: read to the Node CI workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/publish.yml Adds explicit read-only content permissions to the publish workflow
.github/workflows/nodejs.yml Adds explicit read-only content permissions to the Node CI workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,4 +1,6 @@
name: Publish
permissions:
contents: read
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish workflow likely needs write permissions to publish packages. Setting contents: read may be too restrictive if this workflow publishes releases or pushes tags. Consider whether contents: write or additional permissions (e.g., packages: write) are needed for the publish operation to succeed.

Suggested change
contents: read
contents: write
packages: write

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants