CLIENT_DEPRECATE_EOF #1059
Merged
CLIENT_DEPRECATE_EOF #1059
+87
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
client-deprecate-eof
branch
3 times, most recently
from
9225771 to
19e6e0e
Compare
lance6716
reviewed
Oct 19, 2025
|
https://bugs.mysql.com/bug.php?id=91533
Maybe masking added here should also apply to what we send back to server |
Co-authored-by: lance6716 <lance6716@gmail.com>
serprex
force-pushed
the
client-deprecate-eof
branch
from
f5c3949 to
577c6ab
Compare
lance6716
reviewed
Nov 2, 2025
| if s.columns > 0 { | ||
| if err := s.conn.readUntilEOF(); err != nil { | ||
| return nil, errors.Trace(err) | ||
| // TODO process when CLIENT_CACHE_METADATA enabled |
There was a problem hiding this comment.
Do you mean MARIADB_CLIENT_CACHE_METADATA? https://mariadb.com/docs/server/reference/clientserver-protocol/mariadb-protocol-differences-with-mysql
I want to understand what's the effect after this PR. Hope it will not break existing program with that capabilities flag.
There was a problem hiding this comment.
We don't currently support those flags, so it won't affect. We have code that reads until eof to skip info that certain options would omit from protocol
serprex
force-pushed
the
client-deprecate-eof
branch
from
577c6ab to
03f84cc
Compare
lance6716
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a stab at #980
Part of investigating #1056
Something I noticed was that server capabilities aren't limited by what's sent as client capabilities. Reading docs it seems like both ends are expected to look at the intersection of each others flags. So I decided to tweaks things so that
c.capabilitiesis that intersection, rather than whatever server sendsSeems to be working with latest mysql, but on 8.0.25 instead of a hang I get an empty result set back (while
go-sql-driver/mysqlstill pulls the non-empty result)