-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support for ISO 9362:2022 BIC (SWIFT) codes #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4cf1a87 to
664102b
Compare
|
Would it be better to introduce a new validator, such as |
|
sounds good, I can do that, but fyi https://www.iso.org/standard/60390.html the standard is withdrawn, and the 2022 one is inclusive of all old BICs from 2014 one. but if we are to proceed with the namespaced versions, how should we distinguish 2014 and 2022 ones? |
|
Another option is to rename the existing one to |
|
@nodivbyzero Please check at your convenience C: |
|
@fira42073 Lines 1381 to 1386 in 6a38036
|
|
Added, thanks! |
a1f09e0 to
7d20e69
Compare
|
rebased master, but lint is failing for some reason 😕 |
Fixes Or Enhances
#1471
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers