Add IV and KeyID parsing to Dot11WEP #1217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing the IV and Key ID fields in the Dot11WEP layer.
Details
• Added IV [3]byte and KeyID uint8 fields to Dot11WEP
• Updated DecodeFromBytes to:
• Extract the 24-bit IV from the first three bytes
• Extract the 2-bit Key ID from the top bits of the fourth byte
• Updated GoDoc for Dot11WEP to document the header layout
Why
The IV and Key ID are essential for WEP decryption and analysis. Previously, users needed to parse these fields manually from the payload. Exposing them in Dot11WEP simplifies working with WEP frames and brings the layer in line with how other 802.11 fields are exposed.