Skip to content

Conversation

@lalten
Copy link
Contributor

@lalten lalten commented Sep 16, 2022

The web interface is currently broken on master and won't build.

This PR:

  • Fixes the missing SafeHtml type
  • Reverts the (partial?) update to Angular 10
  • Reverts a change in a spec file to be compatible with Angular 4 again
  • Replaces optimization in webpack with Terser (was: built-in UglifyJS)
  • Adds a new build of the web_gui (this commit could be dropped)

Fixes #1039


This change is Reviewable

@lalten lalten force-pushed the laurenz/fix-missing-safehtml-type branch from 505b7f9 to 1d3f406 Compare September 23, 2022 18:43
@lalten lalten changed the title Fix missing SafeHtml type Fix web_gui build Sep 23, 2022
@lalten
Copy link
Contributor Author

lalten commented Sep 23, 2022

@dbhatman This fixes the web_gui and would allow the changes in #1036.

@lalten
Copy link
Contributor Author

lalten commented Oct 8, 2022

@glados-verma @dbhatman would be happy to get your eyes on this.
Note that with a788f96 I added a CI stage to assert the web_gui build continues to work in the future

Copy link
Collaborator

@glados-verma glados-verma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your excellent work @lalten !

Note for any future readers - we still need to downgrade the Node version (e.g. via the n command) to v9 in order to build this (PR #1024 might help us use newer Node versions). Additionally the instructions in CONTRIBUTDING.md are outdated; check the README.md in the web_gui directory (I'll fix the docs in a separate PR).

@glados-verma glados-verma merged commit 7581ab2 into google:master Oct 11, 2022
@lalten lalten deleted the laurenz/fix-missing-safehtml-type branch October 11, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

web_gui build is broken

2 participants