Remove legacy pylint settings and migrate bad-functions configuration #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drop unsupported pylint options (profile, files-output, comment, required-attributes, no-space-check, zope, ignore-iface-methods) that are deprecated or removed. - Remove reference to pylint_plugins.mutablerecords_plugin (deleted in commit google#960). - Migrate bad-functions setting into pylint.extensions.bad_builtin plugin. - Update overgeneral-exceptions to fully qualified builtins.Exception. Align .pylintrc with current pylint conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to
CONTRIBUTING.md, new contributions must pass pylint checks.The
.pylintrcfile, however, has not been updated in about eight years and still containsoptions that are no longer supported or used in recent pylint releases.
This PR refreshes the pylint configuration to align with current pylint behavior
and remove legacy settings that no longer have any effect.
Changes
profile,files-output,comment,required-attributes,no-space-check,zope, andignore-iface-methods.pylint_plugins.mutablerecords_plugin, which was deleted in commit Branches #960.bad-functionshandling to thepylint.extensions.bad_builtinplugin.overgeneral-exceptionsto use fully-qualifiedbuiltins.Exception.