feat: make probe_duration_seconds match probe_script_duration_seconds
#1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
k6-version-report
branch
2 times, most recently
from
11eb79b to
1654602
Compare
nadiamoe
commented
Nov 6, 2025
nadiamoe
force-pushed
the
k6-version-report
branch
from
b86be0c to
f39b2c7
Compare
…nds` For the vast majority of check types, `probe_duration_seconds` is reported as the wall time that took to run the prober. This is accurate for the vast majority of cases, but there's one in particular where it is not: k6-backed checks that use external runners. External runners can take a certain time to process a request, which prior to this commit was counted as part of `probe_duration_seconds` while in fact it was not. This commit adds code that parses the `probe_script_duration_seconds` metric returned by k6 runners, and uses that as the duration of the check for both logs and `probe_duration_seconds`.
nadiamoe
force-pushed
the
k6-version-report
branch
from
f39b2c7 to
c8e3b29
Compare
The-9880
approved these changes
Nov 7, 2025
Member
Author
|
I'll hold this one for the weekend and merge it early next week after the release, so we have time to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the vast majority of check types,
probe_duration_secondsis reported as the wall time that took to run the prober. This is accurate for the vast majority of cases, but there's one in particular where it is not: k6-backed checks that use external runners.External runners can take a certain time to process a request, which prior to this commit was counted as part of
probe_duration_secondswhile in fact it was not. This commit adds code that parses theprobe_script_duration_secondsmetric returned by k6 runners, and uses that as the duration of the check for both logs andprobe_duration_seconds.Fixes #1508