added js/css and updated jinja template to do away with CDNs #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey are the devil in some environments
|
If you want to ensure users are able to upgrade, and that this package doesn't have a fixed dependency, i might reccomend a non-runtime executed utility script to fetch the latest unpkg cdn bundle, and then cache the result in a gitignored path. you can target @latest (stable) and @next (pre-releases). That or a specific version fetched. Either way, this is already a great way to do offline support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use Graphene / Flask-Graphql today at work where I don't have internet access and ran into a problem with Graphiql requiring CDNs to work. I was able to resolve this eventually but wanted to have this in the main line so that I can keep things up to date and not have to worry about my hack at work breaking should we ever rebuild our environment.