Fix 1097 - typescript: add missing constructor definition in generated message classes. #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #1097 by adding a missing constructor definition to generated TypeScript message classes. The change ensures that generated .d.ts files include an explicit constructor signature for classes extending jspb.Message.
- Adds constructor definition with optional
AsObjectparameter to generated TypeScript declaration files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| printer->Indent(); | ||
|
|
||
| printer->Print(vars, "constructor(opt_data?: $class_name$.AsObject);\n"); | ||
|
|
There was a problem hiding this comment.
Trailing whitespace on line 826 should be removed to maintain code cleanliness and comply with most style guides.
Suggested change
sampajano
reviewed
Oct 24, 2025
| printer->Print(vars, "export class $class_name$ extends jspb.Message {\n"); | ||
| printer->Indent(); | ||
|
|
||
| printer->Print(vars, "constructor(opt_data?: $class_name$.AsObject);\n"); |
Collaborator
There was a problem hiding this comment.
@Vuhag123 Thanks! for the change!
One request: Can you provide an example output in the PR description, and try verifying this change works (via a typescript example)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix (#1097) - typescript: add missing constructor definition in generated message classes.