Skip to content

Conversation

@spacefall
Copy link

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

Check off the following to let the reviewers know you've done everything:

  • I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)

  • I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME

  • I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)

  • I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)

  • MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.

  • IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:

  • Full render including all the parts

  • A few sentences about the inspiration and challenges

  • BOM

  • Photos of the Schematic, PCB, and case

If you're unsure about the format, make sure to check out this example and follow the format there.

If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!

@vercel
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2025 7:47pm

Copy link
Contributor

@danieliscrazy danieliscrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! It seems you submitted your hackpad as a submodule. Your hackpad cannot be reviewed or accepted like this. Please fork the hackpad repo and edit the fork. If you're not able to update this PR with that, I assume you will be okay submitting a new PR as long as you say why and reference this PR.

@spacefall
Copy link
Author

Ok, I copied everything to the folder, hopefully I didn't break this PR

Copy link
Contributor

@danieliscrazy danieliscrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be fixed now. Everything looks good, only thing I noticed is that both parts of your case must be branded. Once you've fixed that, I'll give you my approval.

@spacefall
Copy link
Author

Fixed, thanks!

Copy link
Contributor

@danieliscrazy danieliscrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me! This gets my approval! My PR: #590

Copy link
Collaborator

@Overlord-Runt Overlord-Runt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just can you delete the libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants