Skip to content

Conversation

@tektaxi
Copy link
Contributor

@tektaxi tektaxi commented Oct 30, 2025

Tickets:

  • HAC-

List of changes:

  • Some people use multiple sets of pronouns (ex. they/he, she/they, she/he, etc.), this change allows people to select multiple from the dropdown
  • Changed "pronoun" field from type string to type String[] along with relevant validators

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tested locally with corresponding dashboard changes

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

  • anything I'm missing to ensure backwards compatibility with when pronouns were just a string? I don't think so, but I wanna double check. I believe that is just handled in the frontend and nothing here

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@janekhuong janekhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and functions as expected. The only thing you might want to do is update the test files, since they still have pronouns as strings. i.e. in tests/util/account.test.util.js, pronoun: "They/Them" should be ["They/Them"], etc

@tektaxi
Copy link
Contributor Author

tektaxi commented Nov 7, 2025

@janekhuong good catch! will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants