Skip to content

Conversation

@oysteinmoseng
Copy link
Member

No description provided.

Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things need a fix or clarification.

README.md Outdated
Comment on lines 86 to 92
import * as Highcharts from 'highcharts';
// Or load Stock, Maps, or Gantt
// import Highcharts from 'highcharts/highstock';

// Load additional modules as needed
import * as Exporting from 'highcharts/modules/exporting';
Exporting(Highcharts);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect:

import Highcharts from 'highcharts/esm/highcharts.js';
// Or load Stock, Maps, or Gantt
// import Highcharts from 'highcharts/esm/highstock.js';

// Load additional modules as needed
import 'highcharts/esm/modules/exporting.js';

or at least as it was before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was afraid something would be outdated around this, we have pretty confusing installation docs at the moment with many variations across READMEs and our tutorial docs. Correct now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants