Skip to content

Solving #23 Issue in the checkbox component, it is not showing the code correctly and showing a error message #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Solving #23 Issue in the checkbox component, it is not showing the code correctly and showing a error message #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b20d24
Setup a basic badge component
Jul 27, 2024
55fdc20
made the checkbox on by default using the vue code and remove ref whi…
Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these changes.

Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,6 @@
"types": "./dist/src/helpers/index.d.ts"
}
},
"types": "./dist/index.d.ts"
"types": "./dist/index.d.ts",
"packageManager": "pnpm@9.5.0+sha256.dbdf5961c32909fb030595a9daa1dae720162e658609a8f92f2fa99835510ca5"
}
2 changes: 1 addition & 1 deletion src/components/smart/Checkbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const checkboxID = `checkbox-${checkboxIDCounter++}`
defineProps({
on: {
type: Boolean,
default: false,
default: true, // Set default to true
},
name: {
type: String,
Expand Down
2 changes: 1 addition & 1 deletion src/components/smart/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ export { default as HoppSmartPicture } from "./Picture.vue"
export { default as HoppSmartPlaceholder } from "./Placeholder.vue"
export { default as HoppSmartTree } from "./Tree.vue"
export { default as HoppSmartTreeBranch } from "./TreeBranch.vue"
export { default as HoppSmartSelectWrapper } from "./SelectWrapper.vue"
export { default as HoppSmartSelectWrapper } from "./SelectWrapper.vue"
6 changes: 1 addition & 5 deletions src/stories/Checkbox.story.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
<template>
<Story title="Checkbox">
<Variant title="Single">
<HoppSmartCheckbox :on="on" />
<HoppSmartCheckbox />
</Variant>
</Story>
</template>

<script setup lang="ts">
import { HoppSmartCheckbox } from "../components/smart"

import { ref } from "vue"

const on = ref(true)
</script>