Skip to content

Catch IsADirectoryError from Path.touch #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Catch IsADirectoryError from Path.touch #893

wants to merge 2 commits into from

Conversation

@hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl self-assigned this Oct 30, 2025
@hwikle-lanl hwikle-lanl changed the title Catch NotADirectoryError from Path.touch Catch IsADirectoryError from Path.touch Oct 30, 2025
@hwikle-lanl
Copy link
Collaborator Author

Path.touch will raise an IsADirectoryError under certain circumstances, which I've verified PerfEng's working directory meets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Paul-Ferrell Paul-Ferrell Paul-Ferrell approved these changes

Assignees

@hwikle-lanl hwikle-lanl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hwikle-lanl @Paul-Ferrell