-
Notifications
You must be signed in to change notification settings - Fork 0
Scripts and CI utilities #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s (develop-only admin update)
thejhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
|
Let's disable CI rules until we get them fixed. |
thejhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's disable CI rules until they will be fixed
|
Instead of disabling, you could also create a new PR for CI rules and remove CI rules from this one. |
thejhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to create a PR and branch for the ci workflow. Then remove that code from this branch.
…dispatch (per admin feedback on #42)
04a7ccd to
43be372
Compare
|
Per admin feedback:
If any additional CI adjustments are desired in #57, I’ll handle them there while keeping this PR focused. |
thejhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now
Adds scripts as a submodule and brings in .github/workflows/ci.yml. Scope: scripts/ and CI only. Risk: low; no product code. Tests: CI runs 'make tidy lint test build build-tools' matrix; local shellcheck optional. Tracking: FEATURE_CHECKLIST.md line 'Slice PR — scripts and gh utilities'.