IBX-10854 not possible to hide content draft

src/lib/Repository/ContentService.php

@@ -2528,14 +2528,17 @@ public function deleteTranslationFromDraft(APIVersionInfo $versionInfo, string $
      */
     public function hideContent(ContentInfo $contentInfo): void
     {
-        $locationTarget = (new DestinationLocationTarget($contentInfo->mainLocationId, $contentInfo));
-        if (!$this->permissionResolver->canUser(
-            'content',
-            'hide',
-            $contentInfo,
-            [$locationTarget]
-        )) {
-            throw new UnauthorizedException('content', 'hide', ['contentId' => $contentInfo->id]);
+        // If ContentInfo is in draft state, mainLocationId is yet not set
+        if (!$contentInfo->isDraft()) {
+            $locationTarget = (new DestinationLocationTarget($contentInfo->mainLocationId, $contentInfo));
+            if (!$this->permissionResolver->canUser(
+                'content',
+                'hide',
+                $contentInfo,
+                [$locationTarget]
+            )) {
+                throw new UnauthorizedException('content', 'hide', ['contentId' => $contentInfo->id]);
+            }
         }
 
         $this->repository->beginTransaction();
@@ -2568,14 +2571,17 @@ public function hideContent(ContentInfo $contentInfo): void
      */
     public function revealContent(ContentInfo $contentInfo): void
     {
-        $locationTarget = (new DestinationLocationTarget($contentInfo->mainLocationId, $contentInfo));
-        if (!$this->permissionResolver->canUser(
-            'content',
-            'hide',
-            $contentInfo,
-            [$locationTarget]
-        )) {
-            throw new UnauthorizedException('content', 'hide', ['contentId' => $contentInfo->id]);
+        // If ContentInfo is in draft state, mainLocationId is yet not set
+        if (!$contentInfo->isDraft()) {
+            $locationTarget = (new DestinationLocationTarget($contentInfo->mainLocationId, $contentInfo));
+            if (!$this->permissionResolver->canUser(
+                'content',
+                'hide',
+                $contentInfo,
+                [$locationTarget]
+            )) {
+                throw new UnauthorizedException('content', 'hide', ['contentId' => $contentInfo->id]);
+            }
         }
 
         $this->repository->beginTransaction();

tests/integration/Core/Repository/ContentServiceTest.php

@@ -3610,7 +3610,7 @@
             $demoDesign
         );
 
         $demoDesignLocation = $this->locationService->loadLocation($demoDesign->mainLocationId);
 
         // Trashing Content's last Location will change its status to archived,
         // in this case relation towards it will not be loaded.
@@ -6229,6 +6229,76 @@
         $this->assertEquals($hiddenLocations, $hiddenLocationsAfterReveal);
     }
 
+    /**
+     * @covers \Ibexa\Contracts\Core\Repository\ContentService::hideContent
+
+     *
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\APIInvalidArgumentException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\BadStateException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\ContentFieldValidationException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\ContentValidationException
+     */
+    public function testHideContentDraft(): void
+    {
+        $publishedContent = $this->createContentForHideRevealDraftTests(false);
+        $location = $this->locationService->loadLocation($publishedContent->contentInfo->mainLocationId);
+
+        $content = $this->contentService->loadContent($publishedContent->contentInfo->id);
+        self::assertTrue($content->contentInfo->isHidden, 'Content is not hidden');
+        self::assertTrue($location->isHidden(), 'Location is visible');
+    }
+
+    /**
+     * @covers \Ibexa\Contracts\Core\Repository\ContentService::revealContent
+
+     *
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException
+     */
+    public function testHideAndRevealContentDraft(): void
+    {
+        $publishedContent = $this->createContentForHideRevealDraftTests(true);
+        $location = $this->locationService->loadLocation($publishedContent->contentInfo->mainLocationId);
+
+        $content = $this->contentService->loadContent($publishedContent->contentInfo->id);
+        self::assertFalse($content->contentInfo->isHidden, 'Content is hidden');
+        self::assertFalse($location->isHidden(), 'Location is hidden');
+    }
+
+    /**
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\APIInvalidArgumentException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\BadStateException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\ContentFieldValidationException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\ContentValidationException
+     */
+    private function createContentForHideRevealDraftTests(bool $hideAndRevel): Content
+    {
+        $contentTypeService = $this->getRepository()->getContentTypeService();
+
+        $locationCreateStructs = $this->locationService->newLocationCreateStruct(2);
+
+        $contentType = $contentTypeService->loadContentTypeByIdentifier('folder');
+
+        $contentCreate = $this->contentService->newContentCreateStruct($contentType, self::ENG_US);
+        $contentCreate->setField('name', 'Folder to hide');
+
+        $draft = $this->contentService->createContent(
+            $contentCreate,
+            [$locationCreateStructs]
+        );
+
+        $this->contentService->hideContent($draft->contentInfo);
+        if ($hideAndRevel) {
+            $this->contentService->revealContent($draft->contentInfo);
+        }
+
+        return $this->contentService->publishVersion($draft->versionInfo);
+    }
+
     /**
      * @depends testRevealContent
      */
@@ -6328,10 +6398,10 @@
         $this->contentService->revealContent($contents[0]->contentInfo);
 
         $directChildContent = $this->contentService->loadContent($contents[1]->id);
         $directChildLocation = $this->locationService->loadLocation($directChildContent->contentInfo->mainLocationId);
 
         $childContent = $this->contentService->loadContent($contents[2]->id);
         $childLocation = $this->locationService->loadLocation($childContent->contentInfo->mainLocationId);
         $childSublocations = $this->locationService->loadLocationList([
             $contents[3]->contentInfo->mainLocationId,
             $contents[4]->contentInfo->mainLocationId,