Skip to content

Conversation

@qanastek
Copy link
Contributor

No description provided.

qanastek and others added 27 commits July 23, 2025 21:54
- Clean pavel fuction header.

- Add datasets as a dependency
@qanastek
Copy link
Contributor Author

Bug found: Do not merge

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 74.16295% with 463 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.19%. Comparing base (756b18b) to head (84f7da4).
⚠️ Report is 166 commits behind head on main.

Files with missing lines Patch % Lines
src/sdialog/audio/room.py 70.81% 171 Missing ⚠️
src/sdialog/audio/pipeline.py 44.23% 116 Missing ⚠️
src/sdialog/audio/dialog.py 71.94% 39 Missing ⚠️
src/sdialog/audio/voice_database.py 88.88% 34 Missing ⚠️
src/sdialog/audio/tts_engine.py 36.17% 30 Missing ⚠️
src/sdialog/audio/__init__.py 45.00% 22 Missing ⚠️
src/sdialog/audio/acoustics_simulator.py 78.57% 18 Missing ⚠️
src/sdialog/audio/impulse_response_database.py 78.75% 17 Missing ⚠️
src/sdialog/audio/dscaper_utils.py 87.50% 8 Missing ⚠️
src/sdialog/__init__.py 16.66% 5 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   46.82%   55.19%   +8.36%     
==========================================
  Files          20       34      +14     
  Lines        4171     5963    +1792     
==========================================
+ Hits         1953     3291    +1338     
- Misses       2218     2672     +454     
Files with missing lines Coverage Δ
src/sdialog/audio/jsalt.py 100.00% <100.00%> (ø)
src/sdialog/audio/turn.py 100.00% <100.00%> (ø)
src/sdialog/audio/utils.py 100.00% <100.00%> (ø)
src/sdialog/audio/processing.py 96.66% <96.66%> (ø)
src/sdialog/audio/room_generator.py 94.59% <94.59%> (ø)
src/sdialog/__init__.py 63.08% <16.66%> (-0.79%) ⬇️
src/sdialog/audio/dscaper_utils.py 87.50% <87.50%> (ø)
src/sdialog/audio/impulse_response_database.py 78.75% <78.75%> (ø)
src/sdialog/audio/acoustics_simulator.py 78.57% <78.57%> (ø)
src/sdialog/audio/__init__.py 45.00% <45.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

requirements.txt Outdated
# Used to interface with local or hosted large-language-model backends
ollama
openai

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better if we move these guys to its own requirements-audio.txt so that is then easy to have pip install sdialog[audio]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the requirements-audio.txt and now we need to add the support for pip install sdialog[audio] and add it to the github pipeline.

qanastek and others added 6 commits November 7, 2025 18:43
- Fix weird error in dialog2flow during merging
- Update to_audio docs, comment and add an error requiring user to install the audio submodule dependencies.
- Update all the relative paths in the tutorials
- Fix tutorial 7 not using the downloaded archive
- Update .gitignore with new paths
- Build the changelog locally
…to-speech" feature

- Resample the audio out of the tts when not at self.sampling_rate
- Pass extra arguments for tts during inference
- Rename the "voice" parameter from the tts generators into "speaker_voice" in order to be unique and prevent clashes with kwargs.
- Add comments and simplify the code of the save utterances audios function
- Update the documentation
- Run the tests
- Handle import errors for each BaseTTS subclasses
- Remove speed argument from KokoroTTS inference and put it in the constructor
- Make the sampling rate from the turns public and saved into the serialized file
- Add an alternative for HF TTS in the audio tutorial 1
- Remove useless code in from_turn
- Test serialization in both saving and loading for the AudioDialog
.gitignore Outdated
#audio files
*.wav
*.mp3
*.png
Copy link
Member

@sergioburdisso sergioburdisso Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have pngs to be tracked, like images in the docs and in the README, a wouldn't ignore them. If you have pngs somewhere, may be better to ignore them inside that specific folder, but not globally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have a subfolder for the audio tutorials, I can simply stop tracking the images in it.

tutorials/audio/demo_dialog_doctor_patient.json
tutorials/audio/demo_dialog_doctor_patient_no_age_no_gender.json
tutorials/audio/customer_support_dialogue.json
tutorials/audio/=0.9.4
Copy link
Member

@sergioburdisso sergioburdisso Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one ok? tutorials/audio/=0.9.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's caused by this part of the tutorials using kokoro:

pip install -q kokoro>=0.9.4
apt-get -qq -y install espeak-ng > /dev/null 2>&1

.gitignore Outdated
tutorials/audio/dscaper_data_impulse_response/*
*audio_dialog.json
./src/sdialog/sdialog
tutorials/9.generating_data.ipynb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is a good idea to add a tutorial that doesn't exist as part of the global gitignore of the library

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a tutorial I have locally only for now

@sergioburdisso sergioburdisso merged commit 93fd82d into idiap:main Nov 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants