Skip to content

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Oct 8, 2025

No description provided.

@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 816fda9 to f2b4eb5 Compare October 9, 2025 21:13
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from f2b4eb5 to a766e0e Compare October 9, 2025 21:14
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from a766e0e to 2e469a3 Compare October 9, 2025 21:31
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch 2 times, most recently from 896f37c to f10396e Compare October 10, 2025 19:43
@ldorau
Copy link
Contributor Author

ldorau commented Oct 10, 2025

Rebased

@ldorau ldorau requested a review from slawekptak October 10, 2025 20:09
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch 4 times, most recently from d3db808 to 1c86d5c Compare October 15, 2025 09:04
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 1c86d5c to 8fafee6 Compare October 15, 2025 09:54
@ldorau ldorau changed the title [UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() [UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() Oct 15, 2025
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 1d900ae to 7f75aad Compare October 24, 2025 08:11
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from ab6fe92 to 8e674cd Compare October 24, 2025 08:46
@ldorau
Copy link
Contributor Author

ldorau commented Oct 24, 2025

@mmichel11 The unit test TEST_F(CommandGraphTest, LinearInOrderQueue) added by you fails with my pull request:
https://github.com/intel/llvm/actions/runs/18773795439/job/53563700631#step:13:4820

[ RUN      ] CommandGraphTest.LinearInOrderQueue
/__w/llvm/llvm/src/sycl/unittests/Extensions/CommandGraph/LinearGraphOptimization.cpp:42: Failure
Expected equality of these values:
  GraphImplTest::NumPartitionsInOrder(Impl)
    Which is: 2
  NumLinearChains
    Which is: 3

/__w/llvm/llvm/src/sycl/unittests/Extensions/CommandGraph/LinearGraphOptimization.cpp:43: Failure
Expected equality of these values:
  GraphImplTest::NumSyncPoints(Impl)
    Which is: 3
  0

[  FAILED  ] CommandGraphTest.LinearInOrderQueue (0 ms)

when I re-apply the patch 24f54ea that was reverted later (d25d6d6). This is the only unit test that fails with my pull request. I have no idea why. Do you know what should be changed to make it pass?

@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 8e674cd to 5b4cd9d Compare October 24, 2025 09:37
@mmichel11
Copy link
Contributor

@mmichel11 The unit test TEST_F(CommandGraphTest, LinearInOrderQueue) added by you fails with my pull request: https://github.com/intel/llvm/actions/runs/18773795439/job/53563700631#step:13:4820

[ RUN      ] CommandGraphTest.LinearInOrderQueue
/__w/llvm/llvm/src/sycl/unittests/Extensions/CommandGraph/LinearGraphOptimization.cpp:42: Failure
Expected equality of these values:
  GraphImplTest::NumPartitionsInOrder(Impl)
    Which is: 2
  NumLinearChains
    Which is: 3

/__w/llvm/llvm/src/sycl/unittests/Extensions/CommandGraph/LinearGraphOptimization.cpp:43: Failure
Expected equality of these values:
  GraphImplTest::NumSyncPoints(Impl)
    Which is: 3
  0

[  FAILED  ] CommandGraphTest.LinearInOrderQueue (0 ms)

when I re-apply the patch 24f54ea that was reverted later (d25d6d6). This is the only unit test that fails with my pull request. I have no idea why. Do you know what should be changed to make it pass?

This looks to be reported in #20448, and I was able to reproduce the failure on the main SYCL branch with the same error. I confirmed it is resolved by applying #20451, so you may want to try with those changes. It doesn't appear to me that this PR is related.

@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 215d540 to 5b4cd9d Compare October 24, 2025 13:56
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 5b4cd9d to bab6766 Compare October 24, 2025 14:06
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from bab6766 to 3fb0e02 Compare October 24, 2025 15:05
…ch in one call." (intel#19661)"

This reverts commit d25d6d6.

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
…ts()

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants