Skip to content

[SYCL] Select the proper dependency tracking struct for graphs #20451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

[SYCL] Select the proper dependency tracking struct for graphs #20451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sycl/source/detail/queue_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,8 +638,10 @@ queue_impl::submit_direct(bool CallerNeedsEvent,
CGData.MEvents.push_back(getSyclObjImpl(*ExternalEvent));
}

auto &Deps = hasCommandGraph() ? MExtGraphDeps : MDefaultGraphDeps;

// Sync with the last event for in order queue
EventImplPtr &LastEvent = MDefaultGraphDeps.LastEventPtr;
EventImplPtr &LastEvent = Deps.LastEventPtr;
if (isInOrder() && LastEvent) {
CGData.MEvents.push_back(LastEvent);
}
Expand All @@ -653,9 +655,8 @@ queue_impl::submit_direct(bool CallerNeedsEvent,
MissedCleanupRequests.clear();
});

if (MDefaultGraphDeps.LastBarrier &&
!MDefaultGraphDeps.LastBarrier->isEnqueued()) {
CGData.MEvents.push_back(MDefaultGraphDeps.LastBarrier);
if (Deps.LastBarrier && !Deps.LastBarrier->isEnqueued()) {
CGData.MEvents.push_back(Deps.LastBarrier);
}
}

Expand Down Expand Up @@ -683,7 +684,7 @@ queue_impl::submit_direct(bool CallerNeedsEvent,

// Barrier and un-enqueued commands synchronization for out or order queue
if (!isInOrder() && !EventImpl->isEnqueued()) {
MDefaultGraphDeps.UnenqueuedCmdEvents.push_back(EventImpl);
Deps.UnenqueuedCmdEvents.push_back(EventImpl);
}

return CallerNeedsEvent ? EventImpl : nullptr;
Expand Down