feat: update code/documentation related to rust builds, and update highlights for classes. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tree-sitter grammars for injection languages is public and easy to get. I added instructions on how to include those grammars in one's project if they are developing in Rust.
The AST has changed following the numeric_literal change, which allowed negative values. Updating the expected test result with the new AST so tests still pass.
Right now, syntax highlighting only works on a class that extends something else. However classes that don't extend anything are also valid classes. This change will include those classes in syntax highlighting as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
README.mdwith instructions on how to add injection grammars to your own Rust project.scannerandudl/parser.cto fix any code causing warnings in the rust build (cargo build).Cargo.tomlto include all information needed to publish the crate to crates.io.highlights.scmsuch that it correctly highlights classes, both those that extend something and those that don't. Before, it would only highlight classes that extended something.Testing
Before changes, the highlights.scm file did not register a class as a class if it didn't extend something, as shown below:
With the changes, the class is now registered as a class as expected:
Tested that extends still works:
