This repository was archived by the owner on Sep 12, 2022. It is now read-only.
Major fixes, among them windows file handling #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may also want to look at the panel commit I left out , which contains some of my preferences , but these are not strictly errors, so I left them out. |
ipod825
suggested changes
Dec 8, 2021
|
|
||
|
|
||
| @property | ||
| def cur_buf(self): |
There was a problem hiding this comment.
Could you elaborate what issues you encountered. We already have a a gen_new_buf function called by on_bufenter, which should guarantee that all call to cur_buf to be valid.
| return '/'.join(sp).ljust(width) | ||
| else: | ||
| total += len(sp[i]) - 1 | ||
| return res[-1 * width:] |
There was a problem hiding this comment.
I suppose we never reach this point. Did you encounter any issue or did you see lsp warning? If it's the later, maybe it's ok to just return res?
|
|
||
| if sudo: | ||
| Vim.AsyncRun('sudo {} {} {}'.format(self.ServerCmd, cmd, fname), | ||
| Vim.AsyncRun('sudo {} {} {}'.format(self.ServerCmd, cmd, fname).replace('\\','\\\\'), |
There was a problem hiding this comment.
It's better to put the replace in Vim.AsyncRun
| term=True) | ||
| else: | ||
| Vim.AsyncRun('{} {} {}'.format(self.ServerCmd, cmd, fname), | ||
| Vim.AsyncRun('{} {} {}'.format(self.ServerCmd, cmd, fname).replace('\\','\\\\'), |
|
|
||
| @classmethod | ||
| def cp(self, src_arr, dst, sudo=False, on_exit=None): | ||
| print("uuu",src_arr,dst) |
ipod825
reviewed
Dec 8, 2021
| @property | ||
| def cur_buf(self): | ||
| return self._bufs[Vim.current.buffer.number] | ||
| if Vim.current.buffer.number in self._bufs: |
There was a problem hiding this comment.
Did you encounter a key not found error here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I solved here few errors, some of which I didn't create an issue.
curbuf handling was problematic in a way I don't fully remember. I think it threw an error about out of index of buffers. you probably saw it.
fixing issue #43, windows file operation not workingandfixing windows 1fixes windows file handling issue #43.It really solved FS operations in windows. The thing to note is that you do replace
\\with\\\\before calling vim commands , otherwise\\becomes\and it becomes magic.The silent thing is needed because of errors from time to time.
The missing return caused an error as well.