Test peek #778
Merged
Test peek #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E-A-Griffin
reviewed
Nov 2, 2025
test/clojure/core_test/peek.cljc
Outdated
| #?(:cljs (is (nil? (peek #queue []))) | ||
| :default (is (nil? (peek PersistentQueue/EMPTY)))) | ||
| #?(:cljs (is (= :a (peek #queue [:a :b :c]))) | ||
| :default (is (= :a (peek (conj PersistentQueue/EMPTY :a :b :c)))))) |
There was a problem hiding this comment.
Get what you're going for here (I had a similar suggestion for pop) but after talking with @jeaye I think we're better off not testing clojure.lang.PersistentQueue as most platforms don't support it and it's not something clj/cljr "easily" expose (i.e. there's not a way to naturally construct the structure with some clojure.core function like (queue 0 1 2))
There was a problem hiding this comment.
Removed tests on queues.
This closes jank-lang#393.
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #393.