Skip to content

fixes reference to nixpkgs in pre fetch command #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fixes reference to nixpkgs in pre fetch command #2689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
475398a
fixes reference to nixpkgs in pre fetch command
Sep 1, 2025
66c38f6
fix flake referece, add test
mikeland73 Oct 27, 2025
3c5fda9
Merge branch 'main' into fix-prefetch-reference
mikeland73 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/nix/nix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func savePrintDevEnvCache(path string, out PrintDevEnvOut) error {
func FlakeNixpkgs(commit string) string {
// Using nixpkgs/<commit> means:
// The nixpkgs entry in the flake registry, with its Git revision overridden to a specific value.
return "nixpkgs/" + commit
return "github:NixOS/nixpkgs/" + commit
}

func ExperimentalFlags() []string {
Expand Down
18 changes: 18 additions & 0 deletions internal/nix/nix_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,21 @@ func TestParseInsecurePackagesFromExitError(t *testing.T) {
t.Errorf("Expected package 'python-2.7.18.7', got %s", packages[0])
}
}

func TestFlakeNixpkgs(t *testing.T) {
// Test that FlakeNixpkgs returns the expected string given a commit hash.
commit := "123456abcdef"
expected := "github:NixOS/nixpkgs/123456abcdef"
result := FlakeNixpkgs(commit)
if result != expected {
t.Errorf("FlakeNixpkgs(%q) = %q, want %q", commit, result, expected)
}

// Test with an empty string
commit = ""
expected = "github:NixOS/nixpkgs/"
result = FlakeNixpkgs(commit)
if result != expected {
t.Errorf("FlakeNixpkgs(empty string) = %q, want %q", result, expected)
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test isn't doing much, not sure its worth adding

Loading