Skip to content

Add missing field initializers #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add missing field initializers #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ae6200
Add missing field initializers
cleishm Nov 5, 2025
9c04b39
Set rmt_transmit_config_t::queue_nonblocking to true
cleishm Nov 5, 2025
37e58f0
Wrap .allow_pd fields with check for ESP_IDF_VERSION_VAL(5, 4, 0)
cleishm Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions OneWireESP32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,16 @@ static rmt_symbol_word_t ow_bit1 = {
const rmt_transmit_config_t owtxconf = {
.loop_count = 0,
.flags = {
.eot_level = 1
.eot_level = 1,
.queue_nonblocking = true
}
};
const rmt_receive_config_t owrxconf = {
.signal_range_min_ns = 1000,
.signal_range_max_ns = (OW_RESET_PULSE + OW_RESET_WAIT) * 1000,
.flags = {
.en_partial_rx = false
}
};


Expand Down Expand Up @@ -73,7 +77,16 @@ OneWire32::OneWire32(uint8_t pin){
.gpio_num = owpin,
.clk_src = RMT_CLK_SRC_DEFAULT,
.resolution_hz = 1000000,
.mem_block_symbols = MAX_BLOCKS
.mem_block_symbols = MAX_BLOCKS,
.intr_priority = 0,
.flags = {
.invert_in = 0,
.with_dma = 0,
.io_loop_back = 0,
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0)
.allow_pd = 0
Copy link

@mathieucarbou mathieucarbou Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only #if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0)

#endif
}
};

if(rmt_new_rx_channel(&rxconf, &(owrx)) != ESP_OK) {
Expand All @@ -86,9 +99,15 @@ OneWire32::OneWire32(uint8_t pin){
.resolution_hz = 1000000,
.mem_block_symbols = MAX_BLOCKS,
.trans_queue_depth = 4,
.intr_priority = 0,
.flags = {
.invert_out = 0,
.with_dma = 0,
.io_loop_back = 1,
.io_od_mode = 1
.io_od_mode = 1,
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0)
.allow_pd = 0
Copy link

@mathieucarbou mathieucarbou Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only #if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0)

#endif
}
};

Expand Down