feat: Hide ISRC submission links if ISRCs were already added #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavkj
force-pushed
the
hide-isrc-submission-if-up-to-date
branch
from
779d9ff to
b1ca433
Compare
kellnerd
requested changes
Oct 27, 2025
There was a problem hiding this comment.
Thank you, extending the already necessary MB recording API request is a clever solution as these requests aren't cached. So this is definitely simpler than what I originally had in mind to get the ISRCs from MB in #125.
P.S. Apparently I had already reviewed this a few weeks ago and forgot to submit my comments, oops... I've now adapted them for your rebased PR.
kellnerd
reviewed
Oct 28, 2025
gustavkj
force-pushed
the
hide-isrc-submission-if-up-to-date
branch
from
7c47626 to
684f6ce
Compare
kellnerd
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #125
Hides the ISRC submission section if the recordings already have the ISRCs set.
Some examples to test:
/release/actions?release_mbid=de25aec6-9340-44e5-8584-b3571ca4a7ac/release/actions?release_mbid=6698da2f-8c05-4765-8bf4-4fffe0cebaec/release/actions?musicbrainz=b05b6d2c-8667-470b-b8c0-9581fd2027cb&spotify=70vKZBocKuuWTT08nhVLj8>in=886449193363&itunes=&tidal=®ion=SE&release_mbid=b05b6d2c-8667-470b-b8c0-9581fd2027cb/release/actions?release_mbid=24452979-7205-448d-811f-d03cb649ae3c/release/actions?spotify=2Nqpb6pY4bpsfdTfBavVng>in=00602445196982&deezer=&itunes=®ion=SE&release_mbid=157101a5-f0b7-4d98-b9b2-5ad38a5a4820