drop port forwarding

[dprotaso]

• include a proxy endpoint that routes traffic to the node-server
• reduce frontend nextjs image size to ~300MB

I'm hoping this supplements #6204

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for knative ready!

Name	Link
🔨 Latest commit	638be0e
🔍 Latest deploy log	https://app.netlify.com/projects/knative/deploys/68f111b83e6acf0008b98e4e
😎 Deploy Preview	https://deploy-preview-6444--knative.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[dprotaso]

re-opened so we get the github rate limit fix in main

[Leo6Leo]

Haven't finished it yet. Submitting for the first round of review.

[Leo6Leo]

I have finished most of the review, beside these comments, the rest looks good. I will be manually follow and run through the tutorial later to make sure content is accurate. Thanks @dprotaso !

[Leo6Leo]

It seems like $REGISTRY_PORT value cannot be empty here. If it is, the script will exit with error.

error: error parsing STDIN: error converting YAML to JSON: yaml: line 9: mapping values are not allowed in this context

I haven't used the local registry yet, so couldn't comment on this too much. Originally in the old version of tutorial, the remote registry address is requested.

https://github.com/dprotaso/knative-docs/blob/1ec7a2b8807bd23fcf3c217e0adc5634b5e2d0bf/code-samples/eventing/bookstore-sample-app/solution/solution.sh#L63-L75

[dprotaso]

It looks like these variables are read in line 62/63

[Leo6Leo]

Yes, as github doesn't allow me to comment on that line 😅

Also, since now we are officially recommend users to use KinD, the port and registry could have a default value.

"🔑 Enter the registry port:" can be updated to "🔑 Enter the registry port (e.g. 5001 for KinD local registry):"

[dprotaso]

bump @Leo6Leo

[Leo6Leo]

https://github.com/dprotaso/knative-docs/blob/drop-port-forwarding/code-samples/eventing/bookstore-sample-app/solution/ML-bad-word-filter/func.yaml#L6

The registry route should be updated to dynamic, and use the one that's being provided by the user input.

Also the @sha hash in those func.yaml file seems like causing some errors in the func deploy process. I didn't manage to use func deploy to deploy those ML services. Will continue tmr or the day after.

[Leo6Leo]

Yes, as github doesn't allow me to comment on that line 😅

Also, since now we are officially recommend users to use KinD, the port and registry could have a default value.

"🔑 Enter the registry port:" can be updated to "🔑 Enter the registry port (e.g. 5001 for KinD local registry):"

[dprotaso]

The registry route should be updated to dynamic, and use the one that's being provided by the user input.
Also the @sha hash in those func.yaml file seems like causing some errors in the func deploy process. I didn't manage to use func deploy to deploy those ML services. Will continue tmr or the day after.

Want do make those changes in a follow up?

[Leo6Leo]

@dprotaso #6471

The follow up issue has been created. Another review will be needed after the func issue being fixed.