Skip to content

More support for cluster-api #17636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

More support for cluster-api #17636

wants to merge 7 commits into from
+1,491 −367

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Sep 30, 2025 •
edited
Loading

Less hacky support for GCP, encode more of the logic into controllers.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from zetaab September 30, 2025 22:42
@justinsb justinsb force-pushed the clusterapi_controllers branch 2 times, most recently from c2c7c26 to 5e7c5bb Compare September 30, 2025 22:55
@hakman hakman requested review from hakman and removed request for olemarkus and zetaab September 30, 2025 23:27
@justinsb justinsb force-pushed the clusterapi_controllers branch 4 times, most recently from 80b82ec to 855ef49 Compare October 6, 2025 16:43
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Oct 6, 2025
@justinsb justinsb force-pushed the clusterapi_controllers branch 2 times, most recently from 27f468b to 3e80afa Compare October 7, 2025 16:22
@justinsb
Copy link
Member Author

justinsb commented Oct 7, 2025

/test pull-kops-scenario-clusterapi-gcp

Let's try this new test :-)

@hakman
Copy link
Member

hakman commented Oct 7, 2025

/test pull-kops-scenario-clusterapi-gcp

@hakman hakman force-pushed the clusterapi_controllers branch from b8bc822 to a4fbb3d Compare October 7, 2025 18:06
@hakman
Copy link
Member

hakman commented Oct 7, 2025

/test pull-kops-scenario-clusterapi-gcp

@hakman hakman force-pushed the clusterapi_controllers branch from a4fbb3d to 5496816 Compare October 7, 2025 18:08
@hakman
Copy link
Member

hakman commented Oct 7, 2025

/test pull-kops-scenario-clusterapi-gcp

@justinsb justinsb force-pushed the clusterapi_controllers branch 2 times, most recently from a3ef085 to fb68367 Compare October 7, 2025 22:26
@justinsb
Copy link
Member Author

justinsb commented Oct 7, 2025

/test pull-kops-scenario-clusterapi-gcp

@justinsb justinsb force-pushed the clusterapi_controllers branch from fb68367 to b7f6dc3 Compare October 7, 2025 22:58
@justinsb
Copy link
Member Author

justinsb commented Oct 7, 2025

/test pull-kops-scenario-clusterapi-gcp

@hakman
Copy link
Member

hakman commented Oct 16, 2025

"Could not retrieve location for AWS bucket k8s-kops-prow"

/retest

(We might have deleted the bucket / moved the bucket / I may have broken this, but I figure it's worth a retest first)

We switched the account. 🤣
CC @ameukam

@ameukam
Copy link
Member

ameukam commented Oct 16, 2025

yeah. we need to update the presubmits with a new buckets.

@ameukam
Copy link
Member

ameukam commented Oct 17, 2025

/retest

@hakman
Copy link
Member

hakman commented Oct 17, 2025

/test pull-kops-scenario-clusterapi-gcp

1 similar comment
@justinsb
Copy link
Member Author

/test pull-kops-scenario-clusterapi-gcp

@justinsb justinsb force-pushed the clusterapi_controllers branch from 6c3107f to f81a869 Compare October 18, 2025 13:03
@justinsb
Copy link
Member Author

/test pull-kops-scenario-clusterapi-gcp

I think the problem is that we are being inconsistent in specifying the CI env var, forcing CI=1 as an experiment

@justinsb
Copy link
Member Author

/test pull-kops-scenario-clusterapi-gcp

Looks like I'm missing a wait:

Error from server (InternalError): Internal error occurred: Internal error occurred: conversion webhook for cluster.x-k8s.io/v1beta1, Kind=MachineDeployment failed: Post "https://capi-webhook-service.capi-system.svc:443/convert?timeout=30s": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

@justinsb justinsb force-pushed the clusterapi_controllers branch from f81a869 to e9cdcd0 Compare October 18, 2025 17:12
@justinsb
Copy link
Member Author

/test pull-kops-scenario-clusterapi-gcp

@justinsb
Copy link
Member Author

justinsb commented Oct 18, 2025 •
edited
Loading

/test pull-kops-scenario-clusterapi-gcp

I think we're getting there (🤞 ): we weren't passing the version to container builds, and we weren't passing KOPS_BASE_URL to kops-controller (so it was not using the version of nodeup that we built for capi configurations where kops-controller generates the user-data)

@justinsb
Copy link
Member Author

/test pull-kops-scenario-clusterapi-gcp

Calico did not become ready: system-node-critical pod "calico-node-7s5z8" is not ready (calico-node)

I've seen this a few times, I think it's a calico bug. I was able to remedy it by restarting calico when it happened "locally", but I think it is not related

@justinsb
Copy link
Member Author

Wow - I think that was it! Removing WIP :-)

@justinsb justinsb changed the title WIP: More cluster-api More support for cluster-api Oct 18, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2025
@justinsb justinsb mentioned this pull request Oct 18, 2025
Merged
@hakman
Copy link
Member

hakman commented Oct 20, 2025

@justinsb Time to rebase? 😁

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
justinsb and others added 7 commits October 20, 2025 13:04
@justinsb justinsb force-pushed the clusterapi_controllers branch from 6ed27e2 to cadb7e7 Compare October 20, 2025 13:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@justinsb
Copy link
Member Author

/test pull-kops-scenario-clusterapi-gcp

Rebased ... let's see!

@justinsb
Copy link
Member Author

Rebased and passing tests! (pull-kops-scenario-clusterapi-gcp remains optional for now)

@hakman
Copy link
Member

hakman commented Oct 21, 2025

Rebased and passing tests! (pull-kops-scenario-clusterapi-gcp remains optional for now)

I will start the review later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman requested changes

Assignees

@hakman hakman

Labels

area/addons area/api area/documentation area/kops-controller area/nodeup area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinsb @hakman @k8s-ci-robot @ameukam