-
Notifications
You must be signed in to change notification settings - Fork 15k
[KEP-5440] Add documentation for mutable pod resources while job is suspended #52800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-1.35
Are you sure you want to change the base?
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kannon92 The Netlify build preview is failing because the PR currently doesn’t include the feature gate description file for the new MutablePodResourcesForSuspendedJobs
feature gate. Please add a file named MutablePodResourcesForSuspendedJobs.md
under: content/en/docs/reference/command-line-tools-reference/feature-gates/
For more details, please refer to the documentation here.
Refer (logs here)
9:35:30 PM: ERROR Invalid feature gate: 'MutablePodResourcesForSuspendedJobs' is not recognized or lacks a matching description file in 'en/docs/reference/command-line-tools-reference/feature-gates'
/sig apps |
Hold until the upstream implementation k/k PR kubernetes/kubernetes#132441 is merged. /hold |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ah thanks for that. Pushed up a fix for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Here is some feedback.
Description
Add a section in Job documentation supporting KEP-5440.
Issue
Closes: #