-
Notifications
You must be signed in to change notification settings - Fork 22
[academy-example] Add badge and certificate fields in certification frontmatter #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[academy-example] Add badge and certificate fields in certification frontmatter #86
Conversation
name: "Certification-1" | ||
issuer: "Layer5 Academy" | ||
date: "2025-10-01" | ||
credential_id: "12345" | ||
credential_url: "https://academy.layer5.io/certifications/12345" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not the correct properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Vincamine thanks for the review!
I wanted to clarify a couple of points before updating the frontmatter for Certification-1:
Certificate properties:
The current frontmatter uses name, issuer, date, credential_id, credential_url.
Could you please confirm the exact property names expected by the theme?
For example, should it be title, issued_by, issued_on, link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukulpythondev check this link
png: "https://example.com/badge.png" | ||
svg: "https://example.com/badge.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link should be internal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the badge files be placed under static/images/certifications/ and referenced as internal paths like /images/certifications/.png and /images/certifications/.svg?
@Vincamine, @Nouran-11 , please assist @mukulpythondev in finding closure here. |
|
name: "Certification-1" | ||
issuer: "Layer5 Academy" | ||
date: "2025-10-01" | ||
credential_id: "12345" | ||
credential_url: "https://academy.layer5.io/certifications/12345" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukulpythondev check this link
b94306b
to
cd04442
Compare
@Nouran-11 Made the changes according to given Link |
Notes for Reviewers
This PR adds placeholders for
badge
andcertificate
. Please let me know if you’d like actual asset links or if placeholders are acceptable for now.This PR fixes #83
PR Description
What this PR does
badge
andcertificate
frontmatter items to certification content files.Why this is needed
Signed commits