Skip to content

Conversation

@TamaroWalter
Copy link
Contributor

@TamaroWalter TamaroWalter commented Nov 2, 2025

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

As described in #228, in an "only questioners"-anonymous mode, when a user wanted to edit a post, an error ocurred an the editing was not possible.

What was the problem?
When checking if a post is anonymous, the post_control class sends the $info->discussion with an instance of the discussion class to the is_post_anonymous function. The function although expects a simple stdClass-object and tries to read a private-accessible attribute of the class.

What is the solution?
The discussion class is part of the new posts and discussion structure, that is not implemented in all parts of the plugin. Because of that, some functions work with the old system and the new one. A simple solution so far is the function get_db_object from the discussion class that returns a simple stdClass with the database-attributes of the object, that every function can work with. A To-Do was added for further development.


📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • If there are changes in javascript: I build new .min files with the grunt amd command.
  • If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues

@TamaroWalter TamaroWalter self-assigned this Nov 2, 2025
@TamaroWalter TamaroWalter merged commit d55afde into main Nov 2, 2025
78 checks passed
@TamaroWalter TamaroWalter deleted the fix/editpostanonymous branch November 2, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Editing not possible if ‘only questioner’ is set to anonymous

2 participants